Skip to content

Start runnning tests for aarch64-pc-windows-msvc #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 7, 2025

This target is currently build-only. Switch to the windows-11-arm runner, which allows us to start running tests.

ci: test-libm

This target is currently build-only. Switch to the windows-11-arm
runner, which allows us to start running tests.
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 7, 2025

@dpaoliello by the way, is f16/f128 support for arm64ec on the near future radar? As far as I know, since LLVM21 it is our only remaining target to still have an LLVM crash trying to use the f16 type. (f128 has a bit further to go)

@dpaoliello
Copy link
Contributor

@dpaoliello by the way, is f16/f128 support for arm64ec on the near future radar? As far as I know, since LLVM21 it is our only remaining target to still have an LLVM crash trying to use the f16 type. (f128 has a bit further to go)

I'm afraid that I don't know, my team doesn't own defining the ABI/thunks.

@pmsjt @wesleywiser do either of you know if Arm64EC will have a defined way to define thunks for 16- and 128-bit floating point types?

@tgross35 tgross35 merged commit 610e2d2 into rust-lang:master Aug 7, 2025
140 of 149 checks passed
@tgross35 tgross35 deleted the aarch64-msvc-ci branch August 7, 2025 22:55
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 7, 2025

I assumed you may be the one to know since you self-assigned llvm/llvm-project#94434 :)

I would expect at least f16 should be reasonably easy, given aarch64 hardware support and a de facto x86 ABI of passing and returning in xmm (of course that is unfortunately not MSVC-blessed though). That's the type we are much closer to stabilizing anyway.

@wesleywiser
Copy link
Member

Unfortunately, I don't have any information on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants